Skip to content

Handle multiple levels of substitutions and indexed accesses in getActualTypeVariable #52848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 3 commits into from
Feb 21, 2023
Merged

Handle multiple levels of substitutions and indexed accesses in getActualTypeVariable #52848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44887b0
Add test
jakebailey Feb 19, 2023
58ccfee
Handle multiple levesl of substitutions and indexed accesses in getAc…
jakebailey Feb 19, 2023
54221fd
Pull whole test from issue
jakebailey Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle multiple levesl of substitutions and indexed accesses in getAc… 
…tualTypeVariable
  • Loading branch information
@jakebailey
jakebailey committed Feb 19, 2023
commit 58ccfeeee50749fe4529f7a02aa2040495eaab16
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17624,7 +17624,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function getActualTypeVariable(type: Type): Type {
if (type.flags & TypeFlags.Substitution) {
return (type as SubstitutionType).baseType;
return getActualTypeVariable((type as SubstitutionType).baseType);
}
if (type.flags & TypeFlags.IndexedAccess && (
(type as IndexedAccessType).objectType.flags & TypeFlags.Substitution ||
Expand Down
27 changes: 0 additions & 27 deletions tests/baselines/reference/inferRestArgumentsMappedTuple.errors.txt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/baselines/reference/inferRestArgumentsMappedTuple.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ declare function extractPrimitivesOld<Tuple extends any[]>(...mappedTypes: Tuple
// [string, number]
const myPrimitiveTupleOld: [string, number] = extractPrimitivesOld({ primitive: "" }, { primitive: 0 });
>myPrimitiveTupleOld : [string, number]
>extractPrimitivesOld({ primitive: "" }, { primitive: 0 }) : [unknown, unknown]
>extractPrimitivesOld({ primitive: "" }, { primitive: 0 }) : [string, number]
>extractPrimitivesOld : <Tuple extends any[]>(...mappedTypes: TupleMapperOld<Tuple>) => Tuple
>{ primitive: "" } : { primitive: string; }
>primitive : string
Expand Down