Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

Update installation process#19

Merged
olgamarti merged 8 commits into
microsoft:masterfrom
dsrodenas:master
Dec 11, 2019
Merged

Update installation process#19
olgamarti merged 8 commits into
microsoft:masterfrom
dsrodenas:master

Conversation

@dsrodenas

Copy link
Copy Markdown
Contributor

Update several steps of the deployment and the documentation:

  • Fix ConfigMap template for the web because there was an issue when the Twitter account and Google Analytics is not set.
  • Change the Setup-Dev-Spaces.ps1 script to accept the name for the Dev Spaces to create. Currently was creating 2 dev spaces named Scott and Jessica.
  • Update Readme and remove Add-Tiller.ps1 script to make it consistent with the current depoyment process with Helm 3.0 (it does not need Tiller anymore).

dsrodenas and others added 8 commits December 4, 2019 14:49
Merge from microsoft Master
…ogle analytincs configuration is empty. Helm couldn't process it.
…aces names instead of having them hardcoded.
Change script to create the dev spaces to accepts the children dev sp…
Fix issue with Deploy\helm\web\templates\configmap.yaml
Update readme and remove Add-Tiller.ps1 script, which is not useful a…
@olgamarti olgamarti closed this Dec 9, 2019
@olgamarti olgamarti reopened this Dec 11, 2019
@olgamarti olgamarti merged commit 864594e into microsoft:master Dec 11, 2019
OriolBonjoch referenced this pull request in OriolBonjoch/RockPaperScissorsLizardSpock Dec 12, 2019
* Fix ConfigMap template for the web for the cases where Twitter and Google analytincs configuration is empty. Helm couldn't process it.

* Change script to create the dev spaces to accepts the children dev spaces names instead of having them hardcoded.

* Update readme and remove Add-Tiller.ps1 script, which is not useful anymore because now it is used Helm 3.0

* Fix typo.
olgamarti pushed a commit that referenced this pull request Apr 17, 2020
* Fixed PHP handle error

* Added responsive styles to leaderBoard (#18)

* removed php insights

* Fix responsive footer styles (#19)

* Added responsive styles to leaderBoard

* Fix responsive footer styles

Co-authored-by: Carlos de Miguel <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants