Conversation
MaggieKimani1
requested review from
baywet,
danielmbaluka,
darrelmiller and
irvinesunday
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
hold before you merge please!
see this comment on other differences #662 (comment)
@baywet Implemented! |
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
thanks for taking in the changes, a few comments.
| transformCommand.Handler = CommandHandler.Create<string, FileInfo, OpenApiSpecVersion?, OpenApiFormat?, string, string, string, bool, bool>( | ||
|
|
||
| transformCommand.Handler = CommandHandler.Create<string, FileInfo, OpenApiSpecVersion?, OpenApiFormat?, LogLevel, string, string, string, bool, bool>( | ||
| OpenApiService.ProcessOpenApiDocument); |
There was a problem hiding this comment.
| OpenApiService.ProcessOpenApiDocument); | |
| await OpenApiService.ProcessOpenApiDocument); |
There was a problem hiding this comment.
ah ignore my confused self, but please double check the system.commandline API recognizes it's now a tasks and blocks on it, I ran into that issue with kiota a while ago and this leads to very confusing behaviours
There was a problem hiding this comment.
Using the await keyword throws the error cannot await "method group"
There was a problem hiding this comment.
Yep sorry, as long as the command invoke blocks on the task we're good
4 participants
As per Kiota's documentation, this PR seeks to align the common parameters between Hidi and Kiota in order to reduce any disparity in the tools.
As of now, these parameters are:
--openapiin Kiota vs--inputin Hidi representing the path to the OpenAPI description/CSDL file used to generate the code files--outputin Kiota vs--outputin Hidi representing the output directory path for the generated code filesThis PR also seeks to add aliases to our existing parameters for simplicity
Fixes #662