Add filterByOperationId command option#636
Merged
MaggieKimani1 merged 31 commits intovnextfrom Nov 5, 2021
Merged
Conversation
…ed on OperationId
darrelmiller
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
| @@ -35,12 +35,20 @@ public static void ProcessOpenApiDocument( | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Defensive programming for the params?
Contributor
Author
There was a problem hiding this comment.
The version and format params have default values, so they can't equate to null at any point.
operationIds is nullable since its an optional filtering parameter.
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
reviewed
Nov 2, 2021
irvinesunday
approved these changes
Nov 4, 2021
darrelmiller
approved these changes
Nov 5, 2021
…o mk/add-filter-commandOption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding a filterByOperationId parameter to the Commandline tool by:
--filterByOperationIdcommand option to thetransformcommandOpenApiFilterServicethat slices an OpenApiDocument based on theoperation IdsprovidedTesting Instructions
.\build.cmdfileopenapi-parsertool locally by running the.\install-tool.ps1script.\artifacts\openapi-parser.exefile and call the transform command--filterByOperationId "operationId"parameter to the transform commandE.g:
.\artifacts\openapi-parser.exe transform --input People.yml --format yaml --output People2.yml --version OpenApi3_0 --filterByOperationId users_UpdateInsightsFixes #631