Adds nullability check to HasOperations method and updates/refactors tests for OpenApiUrlTreeNode#604
Merged
irvinesunday merged 4 commits intomicrosoft:vnextfrom Jun 7, 2021
Merged
Conversation
This helps with simplifying the tests since we are abstracting out the plumbing work required for some of the tests. Since the code is repetitive, this can be refactored out and reused.
baywet
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
HasOperations()method in theOpenApiUrlTreeNode.csclass.labelparam in the above method.OpenApiUrlTreeNodeTests.csinto reusable private properties, and sorts allArgumentExceptionstests to come after the rest of the other tests. This is to help in test organization.ArgumentExceptionstests forCreate()andAttach()methods.