Skip to content

Make Open API Any reader works in the reader project #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuzhg merged 3 commits into from
Nov 2, 2017
Merged

Make Open API Any reader works in the reader project #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
540c834
Make Open API Any reader works in the reader project
xuzhg Nov 2, 2017
3a717f1
resolve the comments to change parameter name and error message name
xuzhg Nov 2, 2017
6ff388e
put the name into the error message for better understanding
xuzhg Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
put the name into the error message for better understanding
  • Loading branch information
@xuzhg
xuzhg committed Nov 2, 2017
commit 6ff388ec45cba0099f3494418ec4861b61c35e15
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi/ExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private static void VerifyExtensionName(string name)

if (!name.StartsWith(OpenApiConstants.OpenApiDocExtensionFieldNamePrefix))
{
throw new OpenApiException(SRResource.ExtensionFieldNameMustBeginWithXDash);
throw new OpenApiException(String.Format(SRResource.ExtensionFieldNameMustBeginWithXDash, name));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi/Properties/SRResource.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi/Properties/SRResource.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<value>The argument '{0}' is null, empty or consists only of white-space.</value>
</data>
<data name="ExtensionFieldNameMustBeginWithXDash" xml:space="preserve">
<value>The filed name of extension doesn't begin with x-.</value>
<value>The filed name '{0}' of extension doesn't begin with x-.</value>
</data>
<data name="OpenApiExceptionGeneralError" xml:space="preserve">
<value>An error occurred while processing the Open API document.</value>
Expand Down