enabling encoding; refactor to use constants#310
Merged
darrelmiller merged 1 commit intomicrosoft:vnextfrom Aug 12, 2018
Merged
enabling encoding; refactor to use constants#310darrelmiller merged 1 commit intomicrosoft:vnextfrom
darrelmiller merged 1 commit intomicrosoft:vnextfrom
Conversation
darrelmiller
approved these changes
Aug 9, 2018
Member
|
Thanks for this PR. I can definitely get this into 1.1. I will try to do it this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #308. it would be great to get this in v1.1.
aside: when is v1.1 due out?