Skip to content

Comments

enable sourcelink#284

Closed
ctaggart wants to merge 2 commits intomicrosoft:masterfrom
ctaggart:sourcelink
Closed

enable sourcelink#284
ctaggart wants to merge 2 commits intomicrosoft:masterfrom
ctaggart:sourcelink

Conversation

@ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Jun 14, 2018

This enables sourcelink using the awesome new version from Microsoft:
https://github.com/dotnet/sourcelink

@ctaggart ctaggart mentioned this pull request Jun 14, 2018
Closed
@ctaggart
Copy link
Contributor Author

ctaggart commented Jun 14, 2018

The failed test has nothing to do with this pull request:

https://ci.appveyor.com/project/MicrosoftOpenAPINETAdmin/openapi-net/build/1.0.142-qdehlhrl#L257

dotnet test "C:\projects\openapi-net\test\Microsoft.OpenApi.SmokeTests\Microsoft.OpenApi.SmokeTests.csproj" --configuration Release --no-build
Test run for C:\projects\openapi-net\test\Microsoft.OpenApi.SmokeTests\bin\Release\net46\Microsoft.OpenApi.SmokeTests.dll(.NETFramework,Version=v4.6)
Microsoft (R) Test Execution Command Line Tool Version 15.7.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
[xUnit.net 00:00:46.3308794]     APIs.guru(url: "https://api.apis.guru/v2/specs/setlist.fm/1.0/swag"...) [FAIL]
Failed   APIs.guru(url: "https://api.apis.guru/v2/specs/setlist.fm/1.0/swag"...)
Error Message:
 System.UriFormatException : Invalid URI: The URI is empty.
Stack Trace:
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at System.Uri..ctor(String uriString, UriKind uriKind)
   at Microsoft.OpenApi.Readers.V2.OpenApiV2Deserializer.<>c.<.cctor>b__69_171(OpenApiXml o, ParseNode n)
   at Microsoft.OpenApi.Readers.ParseNodes.PropertyNode.ParseField[T](T parentInstance, IDictionary`2 fixedFields, IDictionary`2

@darrelmiller
Copy link
Member

darrelmiller commented Jun 14, 2018

Yeah, the smoke tests are failing due to external data that changed. I disabled the smoketests in the vnext branch.
Thanks for the PR. I'm not familiar with Sourcelink, but I like the sound of it. I will investigate.

@ctaggart
Copy link
Contributor Author

ctaggart commented Jun 14, 2018

There is a brief overview in the "SourceLink" section here:
https://blogs.msdn.microsoft.com/dotnet/2018/05/30/announcing-net-core-2-1/

@ctaggart
Copy link
Contributor Author

ctaggart commented Jun 18, 2018

I'll create a pull request for the vnext branch

@ctaggart ctaggart closed this Jun 18, 2018
@ctaggart ctaggart deleted the sourcelink branch June 18, 2018 15:17
@ctaggart ctaggart mentioned this pull request Jun 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ctaggart @darrelmiller