feat: add support for multiline subtitle#680
Merged
mfontanini merged 2 commits intomfontanini:masterfrom Jul 11, 2025
Merged
Conversation
Closed
Owner
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using slightly modified code from #679 to also allow multiline subtitles.
One thing I didn't have a solution for was the build error in line 94, which will report a PresentationTitle error when there is an error parsing the subtitle, because there is no PresentationSubtitle error, and there is no clean way to separate the cases.
I would argue that this is just a parsing error and the location it happened at should be passed inside it.