Skip to content

Conversation

@evgeny-test
Copy link
Contributor

Fixed no supported S = ${WORKDIR} in styhead.
Fixed missing Upstream-Status in patch QA issue in styhead.
Fix QA Issue: File X in package openjdk-8-src contains reference to TMPDIR [buildpaths]. (issue)
Fix QA Issue: Recipe LICENSE includes obsolete licenses GPLv2+ [obsolete-license].

Hi.

Without these fixes the layer won't build in Yokto 5.1.3 (kas 4.7).

P.S.: I'm going on vacation until March 11. I'll get in touch after that time.

@JerryMain
Copy link
Contributor

JerryMain commented Mar 26, 2025

I can confirm there are issues buiding on master, I was just looking into those myself.

I would suggest you group your changes in smaller commits, e.g. according to https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes

@JerryMain
Copy link
Contributor

also look at your patch status, e.g Upstream-Status: Inappropriate [dead project] should probably be Upstream-Status: Inactive-Upstream [lastcommit: when (and/or) lastrelease: when]. See https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status

@evgeny-test
Copy link
Contributor Author

also look at your patch status, e.g Upstream-Status: Inappropriate [dead project] should probably be Upstream-Status: Inactive-Upstream [lastcommit: when (and/or) lastrelease: when].

The thing is that some of the source codes were made in the late nineties. No source code can be considered original. It is impossible to determine who made the last reliable commit and when.

That's why I used the wording that the developer of this recipe had previously used for other patches.

@evgeny-test
Copy link
Contributor Author

I would suggest you group your changes in smaller commits

I split one commit into several, separating them by meaning.

@evgeny-test
Copy link
Contributor Author

Guys, is there anything else needed for acceptance? How about a merge?

@JerryMain
Copy link
Contributor

the tl;dr would be have openjdk-8-test-image and openjre-8-test-image buildable for qemuarm, qemuarm64 and qemux86-64,

I'll refer you to https://lists.yoctoproject.org/g/yocto-patches/message/986 for the details

unfortunately I haven't had the time to look into that, which I wanted to do before this MR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants