workaround NCP5623 and LP5562 I2C builds#9652
Merged
Jorropo merged 1 commit intomeshtastic:developfrom Feb 14, 2026
Merged
Conversation
Theses two appear to be buggy on r1-neo and nomadstar meteor pro, they rely on Wire.h being included previously to their import. Idk why other platforms using the same smart LEDs are working while theses ones don't. This should make CI green on the dev branch.
github-actions
bot
added
needs-review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a workaround for I2C library dependency issues affecting the NCP5623 and LP5562 smart LED drivers on specific nRF52840 variants (r1-neo and nomadstar meteor pro). The NCP5623 and LP5562 libraries don't properly include Wire.h themselves, causing build failures on these platforms.
Changes:
- Added explicit
#include <Wire.h>before including the NCP5623 and LP5562 libraries - Aligns with existing I2C device patterns used throughout the codebase for similar devices
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/AmbientLightingThread.h | Added Wire.h include before NCP5623.h to fix dependency issue |
| src/graphics/NomadStarLED.h | Added Wire.h include before LP5562.h to fix dependency issue |
portablestew
pushed a commit
to portablestew/meshtastic-firmware
that referenced
this pull request
Feb 15, 2026
Theses two appear to be buggy on r1-neo and nomadstar meteor pro, they rely on Wire.h being included previously to their import. Idk why other platforms using the same smart LEDs are working while theses ones don't. This should make CI green on the dev branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theses two appear to be buggy on r1-neo and nomadstar meteor pro, they rely on Wire.h being included previously to their import.
Idk why other platforms using the same smart LEDs are working while theses ones don't.
This should make CI green on the dev branch.