Refactor logging in ProtobufModule#9536
Merged
thebentern merged 3 commits intomeshtastic:developfrom Feb 10, 2026
Merged
Conversation
github-actions
bot
added
needs-review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the logging in ProtobufModule to improve accuracy by moving the "Received" log statement from before the protobuf decode attempt to after successful decode.
Changes:
- Moves the LOG_INFO statement from before the decode attempt (line 84) to inside the successful decode block (lines 92-93)
- This ensures only successfully decoded packets are logged as "Received", preventing spurious logs for malformed packets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payload lengths were spurious and weird. I've looked back at the blame, and it genuinely looks as if this has never worked exactly right. Who can tell?
🤝 Attestations