Skip to content

fix: popup menu story caused has more submenus open #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 3 commits into from
Jan 2, 2025
Merged

fix: popup menu story caused has more submenus open #572

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73de056
fix: popup menu story caused has more submenus open
HalilFocic Nov 11, 2024
14de710
Merge branch 'main' into fix/menu-style-always-displayed-400
tbouffard Jan 2, 2025
c96776f
extract a function for extra elements removal and simplify the query …
tbouffard Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/html/.storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ const resetMaxGraphConfigs = (): void => {
resetVertexHandlerConfig();
};

// This function is a workaround to destroy mxGraph elements that are not released by the previous story.
// See https://github.com/maxGraph/maxGraph/issues/400
function destroyUnreleasedElements() {
document.querySelectorAll('.mxPopupMenu,.mxWindow').forEach((e) => e.remove());
}

const preview: Preview = {
parameters: {
actions: { argTypesRegex: '^on[A-Z].*' },
Expand All @@ -39,6 +45,7 @@ const preview: Preview = {
// inspired by https://github.com/storybookjs/storybook/issues/4997#issuecomment-447301514
(storyFn) => {
resetMaxGraphConfigs();
destroyUnreleasedElements();
return storyFn();
},
],
Expand Down