Skip to content

fix: remove circular dependency in ModelXmlSerializer#396

Merged
tbouffard merged 1 commit intomainfrom
fix/circular_deps_in_ModelXmlSeralizer
Apr 22, 2024
Merged

fix: remove circular dependency in ModelXmlSerializer#396
tbouffard merged 1 commit intomainfrom
fix/circular_deps_in_ModelXmlSeralizer

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Apr 22, 2024

The circular path was

  • node_modules/@maxgraph/core/dist/index.js
  • -> node_modules/@maxgraph/core/dist/serialization/ModelXmlSerializer.js
  • -> node_modules/@maxgraph/core/dist/index.js

It was due to a wrong import of the Codec class. It was not directly imported but it used the main entry point of maxGraph instead.

The circular path was
  - node_modules/@maxgraph/core/dist/index.js
  - -> node_modules/@maxgraph/core/dist/serialization/ModelXmlSerializer.js
  - -> node_modules/@maxgraph/core/dist/index.js

It was due to a wrong import of the Codec class. It was not directly imported but use the main entry
point of maxGraph.
@tbouffard tbouffard added the bug Something isn't working label Apr 22, 2024
@tbouffard tbouffard marked this pull request as ready for review April 22, 2024 18:09
@tbouffard tbouffard merged commit df98075 into main Apr 22, 2024
@tbouffard tbouffard deleted the fix/circular_deps_in_ModelXmlSeralizer branch April 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant