Moving from make.py to Makefile for sphinx-build#9712
Closed
NelleV wants to merge 11 commits into
Closed
Conversation
- Switching to Makefile to build the documentation like the rest of the Python ecosystem. - Related to MEP10 closes #5798
In addition, sphinx 1.6.4 is buggy
Contributor
|
I still think that #9513 is a better fix...
|
Contributor
|
Why does this PR change to use conda on circleci? Also, I'm completely confused as to why this PR needs to change the examples while #9513 doesn't. |
Member
Member
Author
|
I've closed my PR. Both solution work, and I really don't care which one gets in. |
Member
|
@NelleV, thank you for getting this topic rolling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"We still use an ancient make.py that is based on what early versions of sphinx-quickstart used to generate. We should probably modernize this to use a Makefile like current versions of sphinx create."
closes #5798