Style changes omnibus PR by mdboom · Pull Request #5774 · matplotlib/matplotlib

mdboom · 2015-12-31T21:22:00Z

This is the amalgamation of many style changes slated for v2.0, all put together so we can see how these changes interact and work as a whole.

mwaskom · 2016-01-21T18:57:11Z

Is this the right place to comment on style changes, or is there a discussion thread somewhere else?

mdboom · 2016-01-21T19:09:47Z

If you have specific issues related to these changes feel free to make them here, but the ship has largely sailed on subjective decision making.

mwaskom · 2016-01-21T19:22:08Z

bon voyage, then

QuLogic · 2016-01-21T19:45:53Z

This change seems unnecessary.

You mean just the saving, not the spacing change, right? I agree about the saving -- I think that's just left in accidentally.

Yea, just the saving.

mdboom · 2016-01-21T19:50:58Z

Sorry if I seemed prickly -- that wasn't my intention. The longer story is that we have already put out the request for suggested style changes (through promotion at conferences, the mailing list and a banner on the website) -- that generated many PRs from which Thomas and I selected the best options, taking into account "best for the common case" issues, and consistency etc. This PR is the culmination of that and is largely in the round of finding bugs that it reveals, fixing poor interactions between choices etc., but the big design stuff is mostly over so that we can make a 2.0 release without too much further bikeshedding. All that said, we sincerely hope that the style infrastructure will make it easier for those the disagree with the defaults to easily override them.

QuLogic · 2016-01-21T20:00:41Z

The classic style shouldn't be changing, right?

Good catch.

QuLogic · 2016-01-21T20:22:28Z

As I understand it, all the test images should still be using the classic style. Something appears to be wrong with the handle length in legends as they seem to have widened in several images. It is most evident in lib/matplotlib/tests/baseline_images/test_legend/framealpha.png where it reaches the edge of the legend.

Also, maybe the what's new page should mention the classic style?

QuLogic · 2016-01-21T20:23:55Z

A new minor typo.

Tillsten · 2016-01-21T20:29:56Z

I would really like to see more changes to make the legend not so spacious, the defaults are quite unuseable with more than two entries. Also i really dislike the rounded corners, which is a change i never saw discussed anywhere :(.

Tillsten · 2016-01-21T20:35:40Z

I would also like to see the default markersize decreased.

QuLogic · 2016-01-21T21:11:11Z

Is this also going to change (to go along with numpoints), or is that undecided?

yeah, I thought this is what was meant by changing the number of points in the legend.

mdboom · 2016-01-25T13:31:19Z

@Tillsten wrote:

I would really like to see more changes to make the legend not so spacious, the defaults are quite unuseable with more than two entries. Also i really dislike the rounded corners, which is a change i never saw discussed anywhere :(.
I would also like to see the default markersize decreased.

Thanks for the feedback. As things get integrated, it may be that this does or does not make sense. Unfortunately, the official window to provide style suggestions has closed, but we're obviously still open to feedback about things in the existing changes that don't interact well or make specific kinds of common plots much worse.

WeatherGod · 2016-01-26T16:38:39Z

can't use pound sign in rcfile.

WeatherGod · 2016-01-26T16:45:01Z

A comment about the inset locator demo. With the new colors, it is hard to see the inset lines. Personally, I liked the demo the way it was. The new colors there are very dark.

Also, the ticks in that demo just seems "weird" to me. There is no x tick on the left corners, but there is one on the right corner.

Is the current rendering of the docs with this PR available somewhere? Would be interesting to look at the gallary.

mdboom · 2016-01-26T16:51:57Z

A comment about the inset locator demo. With the new colors, it is hard to see the inset lines. Personally, I liked the demo the way it was. The new colors there are very dark.

Makes sense. Easy enough to put it back to the old colors.

Also, the ticks in that demo just seems "weird" to me. There is no x tick on the left corners, but there is one on the right corner.

Good point. I don't think it's a bug -- it's just the new view limiting coming into play. But we could hardcode the limits or change the locator to fix the weirdness.

Is the current rendering of the docs with this PR available somewhere? Would be interesting to look at the gallary.

Not presently, but I'll put it up somewhere to make that easier to do.

tacaswell · 2016-01-26T17:14:27Z

There are some changes to the inset locator demo to disable the auto-ticking which are on master but not in this PR.

mdboom · 2016-01-26T17:20:55Z

Thanks for all the helpful feedback, @WeatherGod -- and sorry for not pushing and sending you on some duplicate work.

WeatherGod · 2016-01-28T15:46:31Z

That test image you uploaded still fails (~5 RMS)

mdboom · 2016-01-28T16:57:02Z

That test image you uploaded still fails (~5 RMS)

Yeah -- I think #5932 fixes that correctly. I'll just wait for that to merge and rebase.

jenshnielsen · 2016-01-28T17:02:13Z

@mdboom That should be on the 2.x branch now since #5934 was merged

zblz · 2016-01-31T12:23:51Z

@mdboom: Has the proposal in #4730 (using labels 0.1, 1, and 10 in log-scaled axes) been accepted as a default change? I cannot find an implementation with rcParams, but I could whip one up.

efiring · 2016-02-08T20:30:18Z

@zblz: In answer to your question, #4730 is not accepted as a default, but will be welcomed as an option with rcParams.

tacaswell · 2016-02-08T21:13:02Z

Merging this as-is so we can see the built docs.

The 3.5 failure looks like travis flakyness, but I will fix in a follow on PR if that is really broken.

API: Style changes omnibus PR

QuLogic · 2016-02-09T03:09:02Z

Now that this PR is merged, where do we give feedback? I see some bugs in the doc build already...

tacaswell · 2016-02-09T03:36:28Z

New issues is probably easiest.

mdboom added the status: needs review label Dec 31, 2015

mdboom added this to the next major release (2.0) milestone Dec 31, 2015

mdboom mentioned this pull request Dec 31, 2015

Rewrite of image infrastructure #5718

Merged

tacaswell mentioned this pull request Jan 3, 2016

Dflt autodateformat #5698

Merged

mdboom force-pushed the style-change2 branch from 61abfe7 to f6f066e Compare January 4, 2016 15:04

mdboom mentioned this pull request Jan 18, 2016

tight_layout doesn't leave enough space between outwards ticks and axes title #5868

Closed

QuLogic reviewed Jan 21, 2016
View reviewed changes

Comment thread examples/pylab_examples/pcolor_demo.py Outdated

QuLogic Jan 21, 2016

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new minor typo.

QuLogic added the API: default changes Changes to default behavior label Jan 21, 2016

QuLogic reviewed Jan 21, 2016
View reviewed changes

mdboom force-pushed the style-change2 branch from d9b8fba to 95572c8 Compare January 25, 2016 22:16

jenshnielsen added 2 commits January 25, 2016 17:28

Change default image interpolation to nearest

14281fd

Change docstring to reflect new default interpolation

76c70be

WeatherGod reviewed Jan 26, 2016
View reviewed changes

Comment thread matplotlibrc.template

WeatherGod Jan 26, 2016

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't use pound sign in rcfile.

mdboom added 8 commits January 26, 2016 16:59

More detail in what's new

caa711b

Remove info about Blues colormap -- we're punting

c2580a5

USe tight_layout rather than hardcoded space

f0e98fa

Don't use jet

7718b15

Don't hardcode linewidth

0aae0f0

Fix comment

f21d5cf

Fix comment

31f28bc

Add missing test file

b394ae7

tacaswell closed this Feb 8, 2016

tacaswell reopened this Feb 8, 2016

tacaswell added status: needs review and removed status: needs review labels Feb 8, 2016

tacaswell added a commit that referenced this pull request Feb 8, 2016

Merge pull request #5774 from mdboom/style-change2

673f6c5

API: Style changes omnibus PR

tacaswell merged commit 673f6c5 into matplotlib:v2.x Feb 8, 2016

tacaswell removed the status: needs review label Feb 8, 2016

jenshnielsen mentioned this pull request Feb 9, 2016

Refresh pgf baseline images. #5727

Merged

QuLogic mentioned this pull request Oct 16, 2016

fix #4854: set default numpoints of legend entries to 1 #5131

Merged

Uh oh!

Conversation

mdboom commented Dec 31, 2015

Uh oh!

mwaskom commented Jan 21, 2016

Uh oh!

mdboom commented Jan 21, 2016

Uh oh!

mwaskom commented Jan 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdboom commented Jan 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Jan 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tillsten commented Jan 21, 2016

Uh oh!

Tillsten commented Jan 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdboom commented Jan 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WeatherGod commented Jan 26, 2016

Uh oh!

mdboom commented Jan 26, 2016

Uh oh!

tacaswell commented Jan 26, 2016

Uh oh!

mdboom commented Jan 26, 2016

Uh oh!

WeatherGod commented Jan 28, 2016

Uh oh!

mdboom commented Jan 28, 2016

Uh oh!

jenshnielsen commented Jan 28, 2016

Uh oh!

zblz commented Jan 31, 2016

Uh oh!

efiring commented Feb 8, 2016

Uh oh!

tacaswell commented Feb 8, 2016

Uh oh!

QuLogic commented Feb 9, 2016

Uh oh!

tacaswell commented Feb 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants