fix #4854: set default numpoints of legend entries to 1#5131
Merged
Conversation
Member
|
The classic style should have numpoints=2, The idea of the classic style is to provide a style that exactly replicates how MPL looked before the default changes. |
Contributor
Author
|
Also apparently the test-images must be updated when the PR is ready. |
Member
|
No the tests run with the classic style as default to avoid having to update all the test images. |
Member
|
Please don't merge this until we have pushed the 1.5 development off the master branch. |
Member
|
Hmmm, that is strange that only the legend_expand tests failed. Could that codepath be utilizing rcparams incorrectly? |
Member
|
@gauteh Can you rebase? I believe something has corrected the failure on master. |
tacaswell
added a commit
that referenced
this pull request
Feb 8, 2016
fix #4854: set default numpoints of legend entries to 1
Member
|
Backported as part of #5774. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check #4854: set default numpoints to 1.
I am a bit unsure abouth wether classic.mplstyle should be changed.