Skip to content

MNT: add @classmethod and remove ignore post #31867#31884

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
myzhang1029:types-31854-31867-followup
Jun 12, 2026
Merged

MNT: add @classmethod and remove ignore post #31867#31884
timhoffm merged 1 commit into
matplotlib:mainfrom
myzhang1029:types-31854-31867-followup

Conversation

@myzhang1029

Copy link
Copy Markdown
Contributor

PR checklist

@timhoffm timhoffm added this to the v3.11.1 milestone Jun 12, 2026
@timhoffm timhoffm merged commit d421cec into matplotlib:main Jun 12, 2026
35 of 38 checks passed
@timhoffm

Copy link
Copy Markdown
Member

Thanks @myzhang1029

@lumberbot-app

lumberbot-app Bot commented Jun 12, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.11.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d421cec6b6212480bd172678b914647b2bc178a2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #31884: MNT: add `@classmethod` and remove `ignore` post #31867'
  1. Push to a named branch:
git push YOURFORK v3.11.x:auto-backport-of-pr-31884-on-v3.11.x
  1. Create a PR against branch v3.11.x, I would have named this PR:

"Backport PR #31884 on branch v3.11.x (MNT: add @classmethod and remove ignore post #31867)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@myzhang1029 myzhang1029 deleted the types-31854-31867-followup branch June 12, 2026 23:07
@timhoffm

Copy link
Copy Markdown
Member

I haven’t checked why The backport fails. Anyway, it’s not worth spending time on since this only fixes a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants