MNT: Make get_default_filetype a classmethod#31867
Merged
Merged
Conversation
FigureCanvasBase defines get_default_filetype as a classmethod, but all derived implementations overwrite this with an instance method. All implementations could even be static. But let's coerce to a classmethod for consistency and to not change the public API of FigureCanvasBase
5 tasks
QuLogic
approved these changes
Jun 10, 2026
ksunden
approved these changes
Jun 10, 2026
Member
|
Oh, I just realized #31867 was merged already; should we not remove the |
Member
|
I think you were meaning to reference something else, that is the number for this... |
Member
Author
|
You likely mean #31854. Yes, matplotlib/lib/matplotlib/backends/backend_pdf.pyi Lines 411 to 412 in 0677cc8 |
Contributor
I was just checking back at this PR. May I go ahead and do this? |
5 tasks
timhoffm
pushed a commit
that referenced
this pull request
Jun 12, 2026
timhoffm
added a commit
that referenced
this pull request
Jun 12, 2026
MNT: add `@classmethod` and remove `ignore` post #31867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FigureCanvasBase defines get_default_filetype as a class method, but all derived implementations overwrite this with an instance method. All implementations could even be static. But let's coerce to a classmethod for consistency and to not change the public API of FigureCanvasBase
matplotlib/lib/matplotlib/backend_bases.py
Lines 2294 to 2295 in 8747449