TST: Fix runtime error checking NaN input to format_cursor_data#30162
Merged
Conversation
timhoffm
approved these changes
Jun 11, 2025
Member
Author
|
Looks like the Python 3.13 builds are hitting the broken installation python/cpython#135151 |
anntzer
requested changes
Jun 11, 2025
anntzer
left a comment
anntzer
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't the warning catch happen in format_cursor_data (or _format_cursor_data_override) so that it indeed doesn't get emitted when the user mouseovers a nan pixel?
Feel free to dismiss if I missed something.
Member
Author
|
Ah, I wasn't sure if that was something that would happen on purpose; if so, then yes we can move it there. |
anntzer
approved these changes
Jun 12, 2025
Contributor
|
@timhoffm Still OK with the new version? |
timhoffm
approved these changes
Jun 12, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 12, 2025
…ut to format_cursor_data
QuLogic
added a commit
that referenced
this pull request
Jun 13, 2025
…162-on-v3.10.x Backport PR #30162 on branch v3.10.x (TST: Fix runtime error checking NaN input to format_cursor_data)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This seems to have changed in NumPy 2.3.0, only on Windows, but there's no reason to not catch this in the test always.
PR checklist