Remove cutout for missing font file in PdfFile._embedTeXFont.#30036
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom May 12, 2025
Merged
Remove cutout for missing font file in PdfFile._embedTeXFont.#30036timhoffm merged 1 commit intomatplotlib:mainfrom
timhoffm merged 1 commit intomatplotlib:mainfrom
Conversation
If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case). (The cutout in _embedTeXFont was introduced first, in ed0066f (2009), but support for that case appears to have been broken a bit later and the check in dviFontName was then introduced in 4fcc0e7 (2016) where it simply improved the clarity of the exception ultimately raised.)
jkseppan
approved these changes
May 11, 2025
Member
jkseppan
left a comment
jkseppan
left a comment
There was a problem hiding this comment.
Makes sense. Reasons for the font to not exist include the pdftexDownloadBase14 option mentioned in this warning and fonts that lack a Type-1 version. My guess is that both are very rare cases, and the error message currently raised is probably good enough.
timhoffm
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If fontfile is None, an error would already have been raised earlier in dviFontName (which explicitly checks for this case).
(The cutout in _embedTeXFont was introduced first, in ed0066f (2009), but support for that case appears to have been broken a bit later and the check in dviFontName was then introduced in 4fcc0e7 (2016) where it simply improved the clarity of the exception ultimately raised. -- attn @jkseppan, who wrote both commits?)
Noted in relation to #29807.
PR summary
PR checklist