Make PdfFile font-related attributes private.#30027
Merged
Merged
Conversation
Member
|
@anntzer please rerun. The test issues come from a broken snowballstemmer release 3.0.0, which now has been yanked and a fixed version published. |
timhoffm
approved these changes
May 8, 2025
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
People could have overwritten the attributes, for which this is not backwards compatible (no property setter). But I regard this as highly unlikely so that I'm ok with this as is.
They are clearly intended for internal use, and we may want to change their internal representation in the future to support xetex/luatex (which expose more font types).
jklymak
approved these changes
May 8, 2025
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are clearly intended for internal use, and we may want to change their internal representation in the future to support xetex/luatex (which expose more font types).
PR summary
PR checklist