ft2font: Split named instance count from style flags#29431
Merged
Conversation
These are unrelated, and breaks the enum since the instance count is outside the defined flags.
QuLogic
added
Release critical
anntzer
approved these changes
Jan 8, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 8, 2025
oscargus
added a commit
that referenced
this pull request
Jan 8, 2025
…431-on-v3.10.x Backport PR #29431 on branch v3.10.x (ft2font: Split named instance count from style flags)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
These are unrelated, and it breaks the enum since the instance count is outside the defined flags.
Note, tests are always 0 since we don't ship variable fonts, but I did test the example on Inter Variable and got 9 as expected.
It's a bit of an API change, but I think small enough to warrant backporting directly instead of the other options in #29396.
Fixes #29396
PR checklist