Label log minor ticks if only one log major tick is drawn.#29054
Merged
Conversation
anntzer
added
API: changes
Contributor
Author
|
Bumping, at least for discussion? |
oscargus
reviewed
Dec 15, 2024
Member
|
I think it makes sense for the default behavior! I do not fully understand the consequences if someone provides a value, though, and therefore how "much breaking" this is. |
greglucas
approved these changes
Dec 17, 2024
greglucas
left a comment
greglucas
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me and seems like a sensible change to the default.
timhoffm
reviewed
Dec 17, 2024
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
IMHO the change is ok, even though it's technically breaking. I doubt somebody is explicitly relying (or wanting) the preivious behavior.
In general, avoiding axis with a single labeled tick seems to be a good idea. Previously, a log axis spanning from 4 to 60 would have its minor ticks unlabeled, LogFormatter making that choice based on the fact that the axis spans more than one decade (60/4>10). Instead, change the interpretation of the first item in `minor_thresholds` to label the minor ticks (by default) if there is only one (or zero) major tick drawn (as is the case for the above axis limits).
timhoffm
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, avoiding axis with a single labeled tick seems to be a good idea. Previously, a log axis spanning from 4 to 60 would have its minor ticks unlabeled, LogFormatter making that choice based on the fact that the axis spans more than one decade (60/4>10). Instead, change the interpretation of the first item in
minor_thresholdsto label the minor ticks (by default) if there is only one (or zero) major tick drawn (as is the case for the above axis limits).Closes #29050, but probably needs to be discussed as that's technically an API break. However, note that this doesn't break any test and I suspect that this case may have been missed previously (I added a test for it).
PR summary
PR checklist