Skip to content

Remove no-longer-necessary KnownFail for python 3.2.#2900

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
bytbox:master
Sep 6, 2014
Merged

Remove no-longer-necessary KnownFail for python 3.2.#2900
tacaswell merged 1 commit into
matplotlib:masterfrom
bytbox:master

Conversation

@bytbox

@bytbox bytbox commented Mar 14, 2014

Copy link
Copy Markdown
Contributor

(To be merged with #2898.)

@bytbox bytbox mentioned this pull request Mar 14, 2014
@tacaswell tacaswell added this to the v1.4.0 milestone Mar 20, 2014
@tacaswell tacaswell modified the milestones: v1.4.x, v1.4.0 Jun 7, 2014
@tacaswell

Copy link
Copy Markdown
Member

punting as the patch didn't actually fix this issue

@pelson

pelson commented Jun 9, 2014

Copy link
Copy Markdown
Member

punting as the patch didn't actually fix this issue

Are you suggesting #1891 needs to be re-opened @tacaswell?

@tacaswell

Copy link
Copy Markdown
Member

No, I was confused when I asked for this PR. The knownfails are there to catch when 3.2 fails on a stalled pipe during the save (I think #2568). #1891 was a different problem with animation saving in py3k.

@WeatherGod

Copy link
Copy Markdown
Member

What is left to review here?

@tacaswell

Copy link
Copy Markdown
Member

If we drop 3.2 from testing, then nothing other wise the bug with stalled pipes is still unresolved.

@tacaswell tacaswell modified the milestones: v1.4.1, v1.4.x Sep 3, 2014
tacaswell added a commit that referenced this pull request Sep 6, 2014
TST : Remove no-longer-necessary KnownFail for python 3.2.

no longer needed, because we are no longer testing 3.2
@tacaswell tacaswell merged commit 80cd156 into matplotlib:master Sep 6, 2014
tacaswell added a commit that referenced this pull request Sep 6, 2014
TST : Remove no-longer-necessary KnownFail for python 3.2.

no longer needed, because we are no longer testing 3.2
@tacaswell

Copy link
Copy Markdown
Member

cherry-picked to 1.4.x as 04617e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants