Remove 3.7-deprecated fontconfig api#27574
Conversation
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Thanks for the PR - I've left a request to update the test intsead of removing it. Otherwise looks 👍
|
|
||
|
|
||
| def test_fontconfig_unknown_constant(): | ||
| with pytest.warns(DeprecationWarning): |
There was a problem hiding this comment.
Instead of deleting this test, could you change the warning check to an error check? That way we can make sure the error is raised as expected.
There was a problem hiding this comment.
I've added the test, please check
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Looks great! Could whoever merges this do a squash merge?
| @@ -1,7 +1,7 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Since pytest is a third party library, it was above the matplotlib import following the PEP8 style guide so ideally it should stay there.
Co-authored-by: Ruth Comer <[email protected]>
QuLogic
changed the title
|
@bawejahritik Thanks for your interest, however we have merged the older pull request that included changes from related comments for this deprecation. We hope to hear from you again! |
6 participants
PR summary
Removal of old and unused API that were marked as deprecated in 3.7 of Matplotlib and the corresponding test.
(issue #26865)
PR checklist