Skip to content

Final remove#27092

Closed
Krrish2512 wants to merge 3 commits into
matplotlib:mainfrom
Krrish2512:final-remove
Closed

Final remove#27092
Krrish2512 wants to merge 3 commits into
matplotlib:mainfrom
Krrish2512:final-remove

Conversation

@Krrish2512

Copy link
Copy Markdown

PR summary

This PR removes the deprecated code during the version 3.7 from lib/matplotlib/gridspec.py and lib/matplotlib/_fontconfig_patterns.py
-->

PR checklist

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@rcomer rcomer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Krrish2512!

The gridspec lines you removed are not actually deprecations, and the deprecations that were in that file were handled at #26885.

"3.7", message=f"Support for unknown constants "
f"({prop[0]!r}) is deprecated since %(since)s and "
f"will be removed %(removal)s.")
continue

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now raise an error.

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much code is removed, as noted by @rcomer.

@rcomer

rcomer commented Mar 3, 2024

Copy link
Copy Markdown
Member

I’m going to close this as #26865 is complete.

@rcomer rcomer closed this Mar 3, 2024
@melissawm melissawm moved this from Waiting for author to Done in First Time Contributors Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants