Add rectangle collection with rotation#26457
Open
ericpre wants to merge 4 commits into
Open
Conversation
21 tasks
ericpre
force-pushed
the
rectangle_collection_rotation
branch
from
a4cd5a6 to
781e7f7
Compare
github-actions
Bot
added
topic: path handling
status: needs rebase
topic: collections and mappables
and removed
status: needs rebase
labels
ericpre
force-pushed
the
rectangle_collection_rotation
branch
from
781e7f7 to
4b0b2fa
Compare
ericpre
force-pushed
the
rectangle_collection_rotation
branch
from
4b0b2fa to
8776d1d
Compare
… as parent class of EllipseCollection and RectangleCollection
ericpre
force-pushed
the
rectangle_collection_rotation
branch
from
8776d1d to
08f2746
Compare
ericpre
force-pushed
the
rectangle_collection_rotation
branch
from
08f2746 to
6cd30bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Based on #26375 with a refactor the
EllipseCollectionto make a more generic collection class handlingwidths,heightsandanglesparameters.Does it deserve an example in the gallery?
PR checklist