Skip to content

MNT: make fig.colorbar(..., ax=INPUT) even more forgiving#24737

Merged
QuLogic merged 3 commits into
matplotlib:mainfrom
tacaswell:mnt/forgiving_colorbar_input
Dec 16, 2022
Merged

MNT: make fig.colorbar(..., ax=INPUT) even more forgiving#24737
QuLogic merged 3 commits into
matplotlib:mainfrom
tacaswell:mnt/forgiving_colorbar_input

Conversation

@tacaswell

Copy link
Copy Markdown
Member

PR Summary

Follow on to #24408

Accept anything that passes np.iterable

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Accept anything that passes `np.iterable`
@tacaswell tacaswell added this to the v3.7.0 milestone Dec 15, 2022
Comment thread lib/matplotlib/colorbar.py Outdated
@QuLogic QuLogic added API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … topic: color/colorbar labels Dec 15, 2022
Comment thread lib/matplotlib/colorbar.py Outdated
We support higher-dimensional arrays (not clear we _should_ but we do).
@timhoffm

Copy link
Copy Markdown
Member

Anybody can merge after CI pass.

@QuLogic QuLogic merged commit 7f5335a into matplotlib:main Dec 16, 2022
@tacaswell tacaswell deleted the mnt/forgiving_colorbar_input branch December 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … topic: color/colorbar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants