Rename outdated seaborn styles.#22317
Conversation
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
Modulo adding a test that this actually warns (just for 1 name).
They are kept available under a versioned name for backcompat.
|
test added. |
|
LGTM, thanks @anntzer |
|
Just wondering, would the spelling |
|
I mildly prefer without the dash as the dash here is specifying something with in the namespace of seaborn styles and the 0.8 is clarifying that it is the namespace of a particular version of seaborn and we do not plan to pick up style sheets for every version of seaborn. On the other hand, I also propose |
|
There is a vague convention in Fedora that compatibility packages be named |
|
The python packaging naming convention is |
|
Those are not backwards-compatibility names though; those are |
|
I don't see (the point of) the distinction, but concerning package compatiblity I'm just a simple user 🤷. |
Changes in matplotlib style name, matplotlib/matplotlib#22317
6 participants
They are kept available under a versioned name for backcompat.
See #20252, #8351, #13680.
attn @mwaskom, I guess.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).