FIX: ensure that used sub-packages are actually imported#22306
Merged
Conversation
jklymak
previously approved these changes
Jan 24, 2022
jklymak
dismissed
their stale review
oops, guess I shouldn't approve if the tests aren't passing. Looks like we have a circular import...
tacaswell
force-pushed
the
fix_missing_import
branch
from
8704345 to
b512c70
Compare
We need to ensure that the sub-module matplotlib.font_manager is imported when it is used in SclarFormater, however if we import it at the top level we will get circular imports. closes matplotlib#22305
tacaswell
force-pushed
the
fix_missing_import
branch
from
b512c70 to
07f7ec6
Compare
Member
Author
|
🐑 Did not run the tests locally before pushing. |
QuLogic
approved these changes
Jan 24, 2022
timhoffm
approved these changes
Jan 24, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 24, 2022
…actually imported
QuLogic
added a commit
that referenced
this pull request
Jan 24, 2022
…306-on-v3.5.x Backport PR #22306 on branch v3.5.x (FIX: ensure that used sub-packages are actually imported)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #22305
We were relying on an implicit import of a sub-module.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).We could test this by adding a sub-process test, but I am not sure that it is worth it. That said, if someone wants a test on this I will add it.