Skip to content

Don't warn on grid removal deprecation if grid is hidden #22285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklymak merged 1 commit into from
Jan 25, 2022
Merged

Don't warn on grid removal deprecation if grid is hidden #22285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5624,8 +5624,11 @@ def _interp_grid(X):
return X, Y, C, shading

def _pcolor_grid_deprecation_helper(self):
if any(axis._major_tick_kw["gridOn"]
for axis in self._get_axis_list()):
grid_active = any(axis._major_tick_kw["gridOn"]
for axis in self._get_axis_list())
# explicit is-True check because get_axisbelow() can also be 'line'
grid_hidden_by_pcolor = self.get_axisbelow() is True
if grid_active and not grid_hidden_by_pcolor:
_api.warn_deprecated(
"3.5", message="Auto-removal of grids by pcolor() and "
"pcolormesh() is deprecated since %(since)s and will be "
Expand Down