Don't warn on grid removal deprecation if grid is hidden#22285
Merged
Conversation
timhoffm
changed the title
jklymak
reviewed
Jan 22, 2022
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
It seems we need a test that this doesn't break in the future? Clearly we don't test with the grid turned on often enough. Otherwise the change seems fine to me.
Fixes matplotlib#21723. See matplotlib#21723 (comment) for a full desciption of motivation and edge cases.
timhoffm
force-pushed
the
grid-removal-deprecation
branch
from
6408397 to
9e6d723
Compare
Member
Author
I have refrained from adding a test because
|
Member
|
The suggestion here was more to make sure we had a couple tests with different styles turned on. The failure with the colorbar was pretty basic, and in a well-used style. However, I'm fine wth the idea that is beyond this PR's scope |
jklymak
approved these changes
Jan 25, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 25, 2022
…if grid is hidden
dstansby
added a commit
that referenced
this pull request
Jan 25, 2022
…285-on-v3.5.x Backport PR #22285 on branch v3.5.x (Don't warn on grid removal deprecation if grid is hidden)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21723.
See #21723 (comment)
for a full desrciption of motivation and edge cases.