Skip to content

TST/MNT: deprecate unused fixture#20795

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
tacaswell:mnt_deprecate_unused_fixture
Aug 6, 2021
Merged

TST/MNT: deprecate unused fixture#20795
jklymak merged 1 commit into
matplotlib:masterfrom
tacaswell:mnt_deprecate_unused_fixture

Conversation

@tacaswell

Copy link
Copy Markdown
Member

This is left over from an early pass at nose -> pytest conversion

PR Summary

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell tacaswell added the API: changes Changes to the public API, typically requiring deprecation. label Aug 5, 2021
@tacaswell tacaswell added this to the v3.6.0 milestone Aug 5, 2021
This is left over from an early pass at nose -> pytest conversion
@tacaswell tacaswell force-pushed the mnt_deprecate_unused_fixture branch from febcaad to 8385d46 Compare August 5, 2021 17:55
@tacaswell

tacaswell commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

I found this while trying to debug the coverage decrease in #19255

@QuLogic

QuLogic commented Aug 6, 2021

Copy link
Copy Markdown
Member

The deprecation says 3.5, but the milestone says 3.6?

@tacaswell tacaswell modified the milestones: v3.6.0, v3.5.0 Aug 6, 2021
@tacaswell

Copy link
Copy Markdown
Member Author

The deprecation says 3.5, but the milestone says 3.6?

User error on my part in milestoning 🐑

@jklymak jklymak merged commit d958497 into matplotlib:master Aug 6, 2021
@tacaswell tacaswell deleted the mnt_deprecate_unused_fixture branch August 6, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants