Add overset/underset whatsnew entry#19497
Conversation
| `.mathtext`, the default TeX layout engine which is shipped along with | ||
| Matplotlib now supports symbols like *overset* and *underset*. | ||
|
|
||
| The structure which should be followed: "\overset{body}{annotation}" or | ||
| "\underset{body}{annotation}", where *body* would be the text "above" or | ||
| "below" the *annotation* - the baseline character. |
There was a problem hiding this comment.
| `.mathtext`, the default TeX layout engine which is shipped along with | |
| Matplotlib now supports symbols like *overset* and *underset*. | |
| The structure which should be followed: "\overset{body}{annotation}" or | |
| "\underset{body}{annotation}", where *body* would be the text "above" or | |
| "below" the *annotation* - the baseline character. | |
| `.mathtext` now supports *overset* and *underset*, called as | |
| ``\overset{body}{annotation}`` or ``\underset{body}{annotation}``, where | |
| *annotation* is the text "above" or "below" the *body*. |
jklymak
left a comment
There was a problem hiding this comment.
Suggest more direct language. Also I think your transposed "body" and "annotation"
👍🏼
matplotlib/lib/matplotlib/_mathtext.py Lines 2875 to 2879 in 56d9e7c |
|
I guess I didn't pay attention in my original review; certainly "body" should be the main thing and "annotation" the out-of-alignment extra thing. |
OK, that is super confusing. In Ooops, crosspost with above. |
|
I can clean the logic up in this PR |
| --------------------------------------------------------------------------- | ||
|
|
||
| `.mathtext` now supports *overset* and *underset*, called as | ||
| ``\overset{body}{annotation}`` or ``\underset{body}{annotation}``, where |
There was a problem hiding this comment.
OK, but now this is wrong again, right?
There was a problem hiding this comment.
Yeah, I blindly copied the suggestion, let me fix that
PR Summary
This is a continuation of the previous PR #18916,
w.r.t. this comment: #18916 (comment)
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).