Skip to content

ENH: errorbar in qt figureoptions#18650

Draft
andyfaff wants to merge 4 commits into
matplotlib:mainfrom
andyfaff:error
Draft

ENH: errorbar in qt figureoptions#18650
andyfaff wants to merge 4 commits into
matplotlib:mainfrom
andyfaff:error

Conversation

@andyfaff

@andyfaff andyfaff commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

PR Summary

I'd like to change various properties of an errorplot using a Qt figureoptions dialogue. This dialog is presented when NavToolBar is created. At the moment errorplots do not show up in the Curves tab, so one can't change their colour, markersize, etc.
This PR detects if an ErrorbarCollection is present, and adds it to the Curves popup list. This permits adjustment of the line/marker properties of the 'host' Line. Pragmatically the bars/caps of the errorplot are set to be the same color as the host Line, and the same linewidth of the host Line.

fixes #18631

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@andyfaff

andyfaff commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

Possibly the most controversial change is adding a generator to flatten a nested sequence, I added this to make it easier to grab all the lines out of ErrorbarCollection.lines.

@QuLogic

QuLogic commented Oct 6, 2020

Copy link
Copy Markdown
Member

There is a flatten in matplotlib.cbook.

@andyfaff

andyfaff commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

I'll remove the flatten I added, and use the other one. Otherwise is the PR in a suitable form?

@andyfaff

andyfaff commented Oct 10, 2020

Copy link
Copy Markdown
Contributor Author

@QuLogic refactored to use flatten from matplotlib.cbook

QuLogic
QuLogic reviewed Oct 16, 2020
View reviewed changes
Comment thread lib/matplotlib/backends/qt_editor/figureoptions.py Outdated
Comment thread lib/matplotlib/backends/qt_editor/figureoptions.py Outdated
@jklymak jklymak marked this pull request as draft April 23, 2021 16:57
@jklymak

jklymak commented Apr 23, 2021

Copy link
Copy Markdown
Member

Who is our figureoption guru? I've never used it, but hopefully someone will step up and shepherd this.

@github-actions

github-actions Bot commented Aug 23, 2023

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

GUI: Qt New feature status: inactive Marked by the “Stale” Github Action status: needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errorbar lines are not present in the Qt NavToolBar --> curves tab

3 participants

@andyfaff @QuLogic @jklymak