Support data reference for hexbin() parameter C#18103
Merged
Merged
Conversation
timhoffm
added
API: consistency
Member
|
Easy! But hard to tell if it worked - is it OK just to assume the preprocessor works because it works on other functions? |
Member
Author
|
I'll answer that with a yes. The preprocessor itself is tested. We don't want to test every variant of possible calls to the plotting functions. |
jklymak
approved these changes
Jul 29, 2020
Member
|
Sure, just wanted to make sure it was tested somewhere. |
Contributor
|
Failing tests are: They're unrelated and passing here for me on OSX on Python 3.8...so do we ignore or re-run? |
Member
|
Those also failed on #18100. So I don't think it is these PRs, though its possible it is a previous PR that has worked its way into master... |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #18097.