Remove API deprecated in 3.1 (part 2)#15890
Closed
timhoffm wants to merge 1 commit into
Closed
Conversation
timhoffm
changed the title
Member
Author
|
For simplicity, will only fix the merge conflict after #15878 is in. |
anntzer
reviewed
Dec 9, 2019
anntzer
reviewed
Dec 9, 2019
anntzer
reviewed
Dec 9, 2019
anntzer
reviewed
Dec 9, 2019
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
from
99635c3 to
f8bc395
Compare
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
from
f8bc395 to
3ca63df
Compare
timhoffm
added
API: changes
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
2 times, most recently
from
3c2ae89 to
0126cc1
Compare
Contributor
|
breakage is real |
Member
Author
|
The failure is due to incomplete removal of |
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
from
0126cc1 to
2b8eb2d
Compare
anntzer
reviewed
Dec 16, 2019
anntzer
reviewed
Dec 16, 2019
anntzer
reviewed
Dec 16, 2019
anntzer
reviewed
Dec 16, 2019
anntzer
reviewed
Dec 16, 2019
anntzer
reviewed
Dec 16, 2019
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
from
2b8eb2d to
16c95a4
Compare
Contributor
|
Failures are real (bunch of mlab tests have to be deleted, in particular). |
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
3 times, most recently
from
6deea2a to
380962a
Compare
Member
Author
|
Still some math-text related image comparison failures. |
Contributor
|
IIRC I had looked into this some time ago and the deprecation of stackrel may be the problematic one? in which case we can defer the removal of that part for now... |
Member
Author
|
I don't think it's |
Member
Author
|
Going to slice this down into smaller chunks to find out what is acutally causing the failure. |
timhoffm
force-pushed
the
remove-3.1-deprecations2
branch
from
380962a to
de69bd8
Compare
6 tasks
Contributor
6 tasks
Member
Author
|
Replaced by the sequence of above PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up and goes on top of to #15878. The are so many changes that I didn't want to put everything in one PR. Even in two parts, each part is quite long.
You may wait until #15878 is merged or just review the second commit in this PR.