Fixes incorrect error bar colors when NaN values are present#13825
Closed
kasanitej wants to merge 3 commits into
Closed
Fixes incorrect error bar colors when NaN values are present#13825kasanitej wants to merge 3 commits into
kasanitej wants to merge 3 commits into
Conversation
Member
|
Please give your PRs descriptive titles; what does this change do? |
Author
|
Hi, This PR pertains to issue reported in #13799. My change will look into the corresponding index of the color of X & Y where there are np.nan, and remove them. Regards, |
Contributor
|
I think(??) the correct fix is to keep the invalid values in everywhere but not plot them, similarly to #12422. |
Author
|
yeah.. that's sound better than removing them. I will check it. Thanks for suggestion. |
NelleV
changed the title
Member
|
I would also raise a warning. |
Member
|
Superseded by #16724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
incorrect error bar colors when NaN values are present
#13799
PR Checklist