-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
issue with display hook in base python repl #4504
Copy link
Copy link
Closed
Labels
API: changesChanges to the public API, typically requiring deprecation.Changes to the public API, typically requiring deprecation.Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
Metadata
Metadata
Assignees
Labels
API: changesChanges to the public API, typically requiring deprecation.Changes to the public API, typically requiring deprecation.Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Type
Fields
Give feedbackNo fields configured for issues without a type.
This only applies to the base
pythonrepl, everything works inIPythonrepls.In discussion on b2fbae7 discovered that
sys.displayhookonly gets evaluated for expressions, not statements.This means that things like
will not trigger the auto-redrawing. This is particularly troubling because this mean
will not trigger a re-draw, but
will.
Due to b2fbae7, where we rely on the auto-redrawing to trigger the
pyplotredrawing this means that manypyplotworkflows in the normal repl are broken (as in things that used to auto-redraw no longer do).The options I think are:
draw_if_interactivewhich maintains some functions as 'special'I suspect that the answer is going to be both 2 and 3. normal python shell keeps current functionality and gains some new functionality, IPython picks up lots of new functionality, and the code base keeps this particular wart.