Conversation
duncanpo
approved these changes
Oct 8, 2025
Member
duncanpo
left a comment
duncanpo
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of very minor issues that you can quickly fix
test/tformat.m
Outdated
|
|
||
| methods (TestMethodSetup) | ||
| function setup(testCase) | ||
| config = fullfile(fileparts(mfilename("fullpath")), "config", "otelcol_config.yml"); |
Member
There was a problem hiding this comment.
This is the default configuration file. You don't need to specify it here. Simply call commonSetup without passing in the configuration and you will get the default.
|
|
||
| value = 30; | ||
| result = opentelemetry.metrics.ObservableResult; | ||
| result = result.observe(value, dictionary({"Level1"}, {"D"},{"Level2"},{"E"})); No newline at end of file |
Member
There was a problem hiding this comment.
Do you really need cell arrays of strings in the dictionary? Can you avoid using cell arrays:
dictionary("Level1", "D", "Level2", "E")
test/thttpheaders.m
Outdated
|
|
||
| methods (TestMethodSetup) | ||
| function setup(testCase) | ||
| config = fullfile(fileparts(mfilename("fullpath")), "config", "otelcol_config.yml"); |
Member
There was a problem hiding this comment.
No need to supply the default configuration.
test/tjsonbytesmapping.m
Outdated
|
|
||
| methods (TestMethodSetup) | ||
| function setup(testCase) | ||
| config = fullfile(fileparts(mfilename("fullpath")), "config", "otelcol_config.yml"); |
Member
There was a problem hiding this comment.
No need to supply default configurations.
test/ttimeout.m
Outdated
|
|
||
| methods (TestMethodSetup) | ||
| function setup(testCase) | ||
| config = fullfile(fileparts(mfilename("fullpath")), "config", "otelcol_config.yml"); |
test/tusejsonname.m
Outdated
|
|
||
| methods (TestMethodSetup) | ||
| function setup(testCase) | ||
| config = fullfile(fileparts(mfilename("fullpath")), "config", "otelcol_config.yml"); |
Member
There was a problem hiding this comment.
default configuration not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some test cases addressing some of the larger code coverage gaps in the codebase.