Pasting html now properly transforms images as configured into local paths. Build instructions for windows updated fixes: #4149 #2510 #2105 #2462#4150
Open
kiliansinger wants to merge 3 commits into
Conversation
copying the images to local filesystem solves marktext#2462
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve MarkText’s HTML paste behavior by converting pasted HTML <img> sources (e.g., remote/data/blob) into locally saved image paths via the configured image handling, and updates Windows build documentation to address recent node-gyp/Python setup failures.
Changes:
- Add HTML paste handling to fetch/convert pasted
<img>sources into locally saved files usingmuya.options.imageAction. - Add helper utilities for deriving filenames/extensions when persisting pasted images.
- Update Windows build instructions with additional
node-gyp/Python (setuptools) steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/muya/lib/contentState/pasteCtrl.js |
Adds logic to detect <img> tags in sanitized pasted HTML and save/replace sources via imageAction. |
docs/dev/BUILD.md |
Documents extra Windows steps intended to fix node-gyp failures (notably missing distutils/setuptools). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+24
to
+31
| const getImageFileName = (mimeType, alt) => { | ||
| const extension = getImageExtension(mimeType) | ||
| const sanitizedAlt = alt && alt.trim() | ||
| ? alt.trim().replace(/[\\/:*?"<>|]+/g, '-') | ||
| : `pasted-image-${getUniqueId()}` | ||
|
|
||
| if (/\.[a-z\d]+$/i.test(sanitizedAlt)) { | ||
| return sanitizedAlt |
Comment on lines
+182
to
+185
| img.src = imageSrc | ||
| img.alt = alt | ||
| image.replaceWith(img) | ||
| } |
| } | ||
|
|
||
| img.src = imageSrc | ||
| img.alt = alt |
| const img = document.createElement('img') | ||
| let imageSrc = src | ||
|
|
||
| if (src && (DATA_URL_REG.test(src) || URL_REG.test(src) || BLOB_URL_REG.test(src))) { |
kiliansinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pasting html now properly transforms images as configured into local paths.
Build instructions for windows updated.