#3949 Support SET_TO_NULL for overloaded target methods, requiring a cast#3988
Open
hduelme wants to merge 4 commits intomapstruct:mainfrom
Open
#3949 Support SET_TO_NULL for overloaded target methods, requiring a cast#3988hduelme wants to merge 4 commits intomapstruct:mainfrom
hduelme wants to merge 4 commits intomapstruct:mainfrom
Conversation
filiphr
requested changes
Feb 2, 2026
processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@filiphr as you suggested, I moved the import logic to the In addition I added the tests where sub-mapping is generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, invalid code is generated when
SET_TO_NULLis used, as described in #3949.This PR changes the generated code to include an explicit cast when more than two setters with the same name are present.
MapStruct does not fully support overloaded target methods yet (see #1135). To account for this limitation, the tests use a workaround: the preferred target type is determined via the getter with the same name to verify that the correct setter is invoked when passing
null.