Skip to content

Avoid unnecessary unboxing of Boolean #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 11 commits into from
Sep 12, 2022
Merged

Avoid unnecessary unboxing of Boolean #3003

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
de048d8
Update Typos in java-doc
prasanth08 Aug 14, 2022
bcbb906
Merge branch 'mapstruct:main' into main
prasanth08 Aug 21, 2022
4ea0b15
Merge branch 'mapstruct:main' into main
prasanth08 Aug 26, 2022
e3729e8
Update Typos in java-doc
prasanth08 Aug 26, 2022
68986c7
Update link typo in java-doc
prasanth08 Aug 29, 2022
238bb58
Fix link close tag in java-doc
prasanth08 Aug 29, 2022
41043c1
Merge remote-tracking branch 'origin/main'
prasanth08 Aug 29, 2022
e9d70bd
Refactor - Avoid unnecessary unboxing, Use List.sort()
prasanth08 Aug 31, 2022
6598183
Follow coding standard
prasanth08 Sep 1, 2022
20b642e
Merge branch 'mapstruct:main' into main
prasanth08 Sep 9, 2022
02e878e
Revert typo jav-doc "enrichments"
prasanth08 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions processor/src/main/java/org/mapstruct/ap/MappingProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import java.io.PrintWriter;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashSet;
import java.util.Iterator;
Expand Down Expand Up @@ -119,7 +118,7 @@ public class MappingProcessor extends AbstractProcessor {
* <p>
* If the hierarchy of a mapper's source/target types is never completed (i.e. the missing super-types are not
* generated by other processors), this mapper will not be generated; That's fine, the compiler will raise an error
* due to the inconsistent Java types used as source or target anyways.
* due to the inconsistent Java types used as source or target anyway.
*/
private Set<DeferredMapper> deferredMappers = new HashSet<>();

Expand All @@ -142,15 +141,15 @@ private Options createOptions() {
String unmappedSourcePolicy = processingEnv.getOptions().get( UNMAPPED_SOURCE_POLICY );

return new Options(
Boolean.valueOf( processingEnv.getOptions().get( SUPPRESS_GENERATOR_TIMESTAMP ) ),
Boolean.valueOf( processingEnv.getOptions().get( SUPPRESS_GENERATOR_VERSION_INFO_COMMENT ) ),
Boolean.parseBoolean( processingEnv.getOptions().get( SUPPRESS_GENERATOR_TIMESTAMP ) ),
Boolean.parseBoolean( processingEnv.getOptions().get( SUPPRESS_GENERATOR_VERSION_INFO_COMMENT ) ),
unmappedTargetPolicy != null ? ReportingPolicyGem.valueOf( unmappedTargetPolicy.toUpperCase() ) : null,
unmappedSourcePolicy != null ? ReportingPolicyGem.valueOf( unmappedSourcePolicy.toUpperCase() ) : null,
processingEnv.getOptions().get( DEFAULT_COMPONENT_MODEL ),
processingEnv.getOptions().get( DEFAULT_INJECTION_STRATEGY ),
Boolean.valueOf( processingEnv.getOptions().get( ALWAYS_GENERATE_SERVICE_FILE ) ),
Boolean.valueOf( processingEnv.getOptions().get( DISABLE_BUILDERS ) ),
Boolean.valueOf( processingEnv.getOptions().get( VERBOSE ) )
Boolean.parseBoolean( processingEnv.getOptions().get( ALWAYS_GENERATE_SERVICE_FILE ) ),
Boolean.parseBoolean( processingEnv.getOptions().get( DISABLE_BUILDERS ) ),
Boolean.parseBoolean( processingEnv.getOptions().get( VERBOSE ) )
);
}

Expand Down Expand Up @@ -352,7 +351,7 @@ private <P, R> R process(ProcessorContext context, ModelElementProcessor<P, R> p

/**
* Retrieves all model element processors, ordered by their priority value
* (with the method retrieval processor having the lowest priority value (1)
* (with the method retrieval processor having the lowest priority value (1))
* and the code generation processor the highest priority value.
*
* @return A list with all model element processors.
Expand All @@ -372,7 +371,7 @@ private <P, R> R process(ProcessorContext context, ModelElementProcessor<P, R> p
processors.add( processorIterator.next() );
}

Collections.sort( processors, new ProcessorComparator() );
processors.sort( new ProcessorComparator() );

return processors;
}
Expand Down