Styles' OFFSET values are saved as ints though they are doubles [issu…#5710
Closed
thisIsShubhamSharma wants to merge 1 commit intoMapServer:masterfrom
thisIsShubhamSharma:patch-1
Closed
Styles' OFFSET values are saved as ints though they are doubles [issu…#5710thisIsShubhamSharma wants to merge 1 commit intoMapServer:masterfrom thisIsShubhamSharma:patch-1
thisIsShubhamSharma wants to merge 1 commit intoMapServer:masterfrom
thisIsShubhamSharma:patch-1
Conversation
Member
|
@thisIsShubhamSharma - you probably want to try the pull request again - there are too many changes to the file to review (https://github.com/mapserver/mapserver/pull/5710/files). If you auto-formatted the code you'll want to revert this and just add the minimal changes required for the fix with no refactoring. |
Author
|
Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e #5310]
fixes #5310 and done some refactoring