Allow providing ec2-instance-count to start multiple runners#165
Closed
dexbleeker wants to merge 2 commits intomachulav:mainfrom
Innico:main
Closed
Allow providing ec2-instance-count to start multiple runners#165dexbleeker wants to merge 2 commits intomachulav:mainfrom Innico:main
dexbleeker wants to merge 2 commits intomachulav:mainfrom
Innico:main
Conversation
|
Works like a charm |
|
Only comments are to update the readme surrounding the outputs and examples (with it now being ec2-instance-ids) |
|
Any plans to merge this? |
|
MinCount/MaxCount are not used anywhere, shouldn't it be a specific count, why there's a min/max, kind of "if at least N will successfully be created" ? |
|
+1 Very useful feature for us too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
This PR is based on the fork of @messense, specifically this commit.
It allows for providing
ec2-instance-countas input variable and will start multiple runners if desired. By default 1 runner is started.Note that this might not be the cleanest code or best implementation. I don't write JS generally and have not touched a GH action before. Especially
Array.from(JSON.parse(ec2InstanceIds))feels wrong.All feedback is welcome however.