Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ProseMirror schema declares an attribute with
default: null,updateLoroMapAttributescallsattrs.delete(key)on every sync even if the key was never written to the Loro map, andLoroMap.deleterecords an op whether or not the key exists. The visible symptom: every editor transaction over such a node produces an empty Loro change, which between two peers becomes an endless idle back-and-forth of updates. It can also lose data, since the spurious delete is a real concurrent op — if peer A setschecked: truewhile peer B types anywhere, B's delete can win the merge and silently revert the attribute, leaving it gone on both peers. Fix: guard the delete with the key set the function already builds fromattrs.keys(), so a null attribute that's actually in the map still gets removed and one that was never there produces no op. Added a test that fails on main with[{ type: 'delete', key: 'checked' }], plus one for the non-null → null case to make sure the real delete path still works.