Skip to content

DataFrame.display injection#514

Merged
metasim merged 10 commits intolocationtech:developfrom
s22s:feature/ipy-display
Oct 27, 2020
Merged

DataFrame.display injection#514
metasim merged 10 commits intolocationtech:developfrom
s22s:feature/ipy-display

Conversation

@metasim
Copy link
Copy Markdown
Member

@metasim metasim commented Oct 19, 2020

  • Patched in pyspark.sql.DataFrame.display function for passing parameters to html rendering code normally invoked through display hooks.
  • Updated Python dependencies.
  • Set default prefer-gdal to false as JVM parser is just as good for most use cases.

Closes #513

TODO:

  • add to users' manual
  • fix build issue with branca:
    NotImplementedError: Can't perform this operation for unregistered loader type

Added `DescribeablePartition` to debugging package.
…g normally called by IPython display.

Upgraded suite of Python dependencies.
@metasim metasim changed the title Feature/ipy display DataFrame.display injection Oct 19, 2020
@metasim metasim requested a review from vpipkt October 19, 2020 21:32
Copy link
Copy Markdown
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

@metasim metasim requested a review from vpipkt October 21, 2020 18:28
Copy link
Copy Markdown
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i couldn't get the docs to build to really see whats goin on but looks pretty good. a few small changes

@metasim
Copy link
Copy Markdown
Member Author

metasim commented Oct 22, 2020

i couldn't get the docs to build to really see whats goin on but looks pretty good. a few small changes

Hint on what was going wrong?

@vpipkt
Copy link
Copy Markdown
Member

vpipkt commented Oct 23, 2020

i couldn't get the docs to build to really see whats goin on but looks pretty good. a few small changes

Hint on what was going wrong?

just some environment cruft on my end.

@metasim metasim requested a review from vpipkt October 26, 2020 13:32
@metasim
Copy link
Copy Markdown
Member Author

metasim commented Oct 26, 2020

@vpipkt FYI, there seems to be a regression in the Unsupervised Machine Learning section of the documentation, where the overview prediction raster rendering is a single color. Will deal with in a subsequent PR.

@metasim metasim merged commit 19191ba into locationtech:develop Oct 27, 2020
@metasim metasim deleted the feature/ipy-display branch October 27, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .display extension function that allows specifying the number of rows

2 participants