🔨 chore: Optimize PR Docker build workflow#13335
🔨 chore: Optimize PR Docker build workflow#13335BrandonStudio wants to merge 1 commit intolobehub:canaryfrom
Conversation
|
@BrandonStudio is attempting to deploy a commit to the LobeHub OSS Team on Vercel. A member of the Team first needs to authorize it. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
@nekomeowww - This is a Docker build CI/DevOps workflow change. Please take a look. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0384c22500
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
Switching the trigger to pull_request_target here changes the checkout context to the repository default branch, so with actions/checkout@v6 left at defaults the workflow now builds and pushes images from default-branch code rather than the PR changes (even though job names and tags imply a PR build). In this workflow (.github/workflows/pr-build-docker.yml), that means labeled/synchronized PRs can publish misleading images and comments that do not correspond to the proposed code unless checkout is pinned to github.event.pull_request.head.sha (or equivalent trusted ref strategy).
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13335 +/- ##
==========================================
- Coverage 66.84% 66.84% -0.01%
==========================================
Files 1891 1891
Lines 151395 151395
Branches 17300 18003 +703
==========================================
- Hits 101206 101204 -2
- Misses 50070 50072 +2
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📝 Additional Information
Do pay special attention to security of secrets