Skip to content

feat: optimize QR code value for bach32#3900

Merged
motorina0 merged 1 commit into
devfrom
uppercase_bech32
Mar 25, 2026
Merged

feat: optimize QR code value for bach32#3900
motorina0 merged 1 commit into
devfrom
uppercase_bech32

Conversation

@motorina0
Copy link
Copy Markdown
Collaborator

@motorina0 motorina0 commented Mar 25, 2026

Bech32 values should always be uppercase (including the prefix).

URLs and other non-bech32 values stay as they are

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (7d734ec) to head (0816026).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3900      +/-   ##
==========================================
- Coverage   56.74%   56.72%   -0.02%     
==========================================
  Files         124      124              
  Lines       16990    16990              
==========================================
- Hits         9641     9638       -3     
- Misses       7349     7352       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arcbtc arcbtc self-requested a review March 25, 2026 13:48
Copy link
Copy Markdown
Member

@dni dni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😷 i dont like

@motorina0 motorina0 merged commit 658da6b into dev Mar 25, 2026
59 of 60 checks passed
@motorina0 motorina0 deleted the uppercase_bech32 branch March 25, 2026 14:22
motorina0 added a commit that referenced this pull request Mar 30, 2026
commit 5999a77
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 30 10:16:01 2026 +0300

    chore(deps): bump cryptography from 46.0.5 to 46.0.6 (#3909)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 7e0fada
Author: dni ⚡ <[email protected]>
Date:   Thu Mar 26 11:28:23 2026 +0100

    refactor: move payment code from `tasks.py` to `service/payments.py` (#3800)

commit b2d6243
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Mar 26 11:07:50 2026 +0200

    chore(deps): bump requests from 2.32.5 to 2.33.0 (#3903)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6b5a77f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Mar 26 09:58:34 2026 +0200

    chore(deps): bump picomatch from 2.3.1 to 2.3.2 (#3901)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit cc8fb68
Author: dni ⚡ <[email protected]>
Date:   Thu Mar 26 08:37:36 2026 +0100

    ci: only run ci on pull request (#3902)

commit 658da6b
Author: Vlad Stan <[email protected]>
Date:   Wed Mar 25 16:22:03 2026 +0200

    feat: optimize QR code value for bach32 (#3900)

commit 7d734ec
Author: Vlad Stan <[email protected]>
Date:   Wed Mar 25 13:10:47 2026 +0200

    fix: use `--offline` for `uv` (#3896)

commit 9177dd1
Author: dni ⚡ <[email protected]>
Date:   Wed Mar 25 12:08:39 2026 +0100

    chore: update to version 1.5.3 (#3899)

commit 15faab4
Author: dni ⚡ <[email protected]>
Date:   Wed Mar 25 11:57:37 2026 +0100

    [feat] reset the first install token (#3894) (#3898)

    Co-authored-by: Vlad Stan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants